Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add missing tests for proto/snpb.(LogStreamUncommitReport) #917

Open
wants to merge 1 commit into
base: tests_validate_topic_logstream
Choose a base branch
from

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Nov 22, 2024

What this PR does

This PR adds missing tests for proto/snpb.(LogStreamUncommitReport).

@ijsong ijsong requested a review from hungryjang as a code owner November 22, 2024 09:36
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.10%. Comparing base (36e61c6) to head (0060a81).

Additional details and impacted files
@@                        Coverage Diff                         @@
##           tests_validate_topic_logstream     #917      +/-   ##
==================================================================
+ Coverage                           78.99%   79.10%   +0.11%     
==================================================================
  Files                                 180      180              
  Lines                               21621    21621              
==================================================================
+ Hits                                17079    17103      +24     
+ Misses                               3722     3702      -20     
+ Partials                              820      816       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong ijsong force-pushed the tests_validate_topic_logstream branch from e92b816 to a0f2401 Compare December 13, 2024 01:52
@ijsong ijsong force-pushed the tests_log_stream_uncommit_report branch from 099dbf1 to fe756d5 Compare December 13, 2024 01:53
@ijsong ijsong force-pushed the tests_validate_topic_logstream branch from a0f2401 to 36e61c6 Compare December 13, 2024 02:01
@ijsong ijsong force-pushed the tests_log_stream_uncommit_report branch from fe756d5 to 0060a81 Compare December 13, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant